-
Notifications
You must be signed in to change notification settings - Fork 51
Add minimal Franka test data example #222
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@StafaH I would leave the primitive colliders as they were (basically undo your last commit) - those work OK and have already been validated in sim2real contexts.
Was there something you had in mind by explicitly removing them?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
two more nits then we are good to go
|
||
<statistic center="0.3 0 0.4" extent="1"/> | ||
|
||
<option timestep="0.005" iterations="5" ls_iterations="8" integrator="implicitfast"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
for MJWarp, we should be able to remove iterations
and ls_iterations
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done!
</option> | ||
|
||
<custom> | ||
<numeric data="12" name="max_contact_points"/> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
for MJWarp, we should be able to remove this whole <custom>
section
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done!
This reverts commit 487b391.
Reverted the primitive collision change. Agree with the sim2real comment to align with previous work. Originally I was just thinking this test data/test case should more more MJWarp related, since the original motivation for the primitive colliders was that mesh collision was too expensive in MJX, but your rationale makes more sense as well. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome, thanks @StafaH !
Adding a minimal example (franka robot and floor) to test data.